Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Allow cache eviction for HNSW provider #2484

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[ENH] Allow cache eviction for HNSW provider #2484

merged 2 commits into from
Jul 16, 2024

Conversation

Ishiihara
Copy link
Contributor

@Ishiihara Ishiihara commented Jul 9, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This PR introduces cache with eviction policy to HNSQ provider, allowing eviction of HNSW files.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Ishiihara Ishiihara mentioned this pull request Jul 9, 2024
Merged
1 task
@Ishiihara Graphite App
Copy link
Contributor Author

Ishiihara commented Jul 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Ishiihara and the rest of your teammates on Graphite Graphite

@Ishiihara Ishiihara mentioned this pull request Jul 9, 2024
Merged
1 task
@Ishiihara Ishiihara marked this pull request as ready for review July 10, 2024 17:09
HammadB
HammadB approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would like us to use try_from_config > new for config and also there are some cleanups like out of date TODOs

@Ishiihara Ishiihara self-assigned this Jul 12, 2024
@Ishiihara Ishiihara changed the base branch from liquan_stream_abstraction to main July 16, 2024 07:46
@Ishiihara Ishiihara merged commit 49686be into main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees

@Ishiihara Ishiihara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ishiihara @HammadB