Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] LogRecord TypedDict attr name incorrect #2486

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 10, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes a typed dict related mypy error where we propagated an incorrect name
    • Fixes other or ignores other type errors
  • New functionality
    • none

Test plan

How are these changes tested?
Existing tests

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB requested a review from atroyn July 10, 2024 04:32
Copy link
Contributor

@atroyn atroyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @HammadB - Approved pending CI

@HammadB HammadB enabled auto-merge (squash) July 10, 2024 04:40
@HammadB HammadB merged commit 27ba303 into main Jul 10, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants