Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] Release 0.5.4. Pin hnswlib upgrade. Configuration b/w compat. #2496

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[RELEASE] Release 0.5.4. Pin hnswlib upgrade. Configuration b/w compat. #2496

merged 2 commits into from
Jul 10, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 10, 2024

  • Release 0.5.4
  • Pin hnswlib upgrades
  • Configuration b/w compat

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

codetheweb
codetheweb approved these changes Jul 10, 2024
View reviewed changes
chromadb/server/fastapi/__init__.py Outdated
# In 0.5.4 we added the configuration field to the CreateCollection model
# This field is optional, so we need to check if it exists in the json
if "configuration" not in json_decode:
json_decode["configuration"] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test/was there manual validation to double check this works with older clients?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did manual validation. we don't really have an easy way to plug in CI tests

@HammadB HammadB enabled auto-merge (squash) July 10, 2024 17:07
@HammadB HammadB merged commit 9c91fe4 into main Jul 10, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HammadB @codetheweb