Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Better tracing for storage access #2500

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[PERF] Better tracing for storage access #2500

merged 1 commit into from
Jul 11, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 11, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Cleaner tracing for reading blocks
    • Cleaner tracing for reading hnsw
Screenshot 2024-07-10 at 7 55 46 PM
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB
HammadB commented Jul 11, 2024
View reviewed changes
rust/worker/src/blockstore/arrow/blockfile.rs
.get_block(target_block_id)
.instrument(tracing::trace_span!(parent: Span::current(), "Get Block", block_id = %target_block_id))
.await;
let block = self.get_block(target_block_id).await;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed these in favor of lower level tracing

HammadB
HammadB commented Jul 11, 2024
View reviewed changes
rust/worker/src/blockstore/arrow/provider.rs
}
}
.instrument(tracing::trace_span!(parent: Span::current(), "BlockManager get cold"))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the extent of the diff

@HammadB HammadB requested a review from sanketkedia July 11, 2024 02:56
@HammadB
Copy link
Collaborator Author

HammadB commented Jul 11, 2024

Merging despite test failure - which I fix in #2501 but that is waiting for review. This change 100% is unrelated to that.

@HammadB HammadB merged commit 45aba8a into main Jul 11, 2024
61 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HammadB