Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] DeprecationWarning in httpx\_content.py:202: #2509

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

LukasWestholt
Copy link
Contributor

@LukasWestholt LukasWestholt commented Jul 12, 2024

I got the warning message httpx\_content.py:202: DeprecationWarning: Use 'content=<...>' to upload raw bytes/text content.

$ pip freeze | grep httpx
httpx==0.27.0

Description of changes

Summarize the changes made by this PR.

  • Maintenance
    • Changes according to DeprecationWarning

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python

Results:

=============================================================================== short test summary info ===============================================================================
FAILED chromadb/test/auth/test_token_authn.py::test_fastapi_server_token_authn_rejects_when_it_should_reject - hypothesis.errors.DeadlineExceeded: Test took 51085.73ms, which exceeds the deadline of 45000.00ms
FAILED chromadb/test/client/test_create_http_client.py::test_main - AssertionError: assert 1 == 0
FAILED chromadb/test/property/test_segment_manager.py::test_segment_manager[fastapi] - ValueError: badly formed hexadecimal UUID string
FAILED chromadb/test/property/test_segment_manager.py::test_segment_manager[async_fastapi] - ValueError: badly formed hexadecimal UUID string
FAILED chromadb/test/property/test_segment_manager.py::test_segment_manager[fastapi_persistent] - ValueError: badly formed hexadecimal UUID string
FAILED chromadb/test/property/test_segment_manager.py::test_segment_manager[sqlite] - ValueError: badly formed hexadecimal UUID string
FAILED chromadb/test/property/test_segment_manager.py::test_segment_manager[sqlite_persistent] - ValueError: badly formed hexadecimal UUID string
FAILED chromadb/test/stress/test_many_collections.py::test_many_collections[sqlite_persistent] - MemoryError: bad allocation
FAILED chromadb/test/test_api.py::test_persist_index_loading[local_persist_api] - onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from C:\Users\lukas\.cache\chroma\onnx_models\all-MiniLM-L6-v2\onnx\model.onnx failed:...
FAILED chromadb/test/test_api.py::test_persist[local_persist_api] - MemoryError: bad allocation
============================================ 10 failed, 857 passed, 44 skipped, 6 xfailed, 5 xpassed, 28676 warnings in 7516.05s (2:05:16) ============================================

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
Yes.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jeffchuber
Copy link
Contributor

@codetheweb codetheweb enabled auto-merge (squash) September 16, 2024 17:30
@codetheweb codetheweb merged commit eba168e into chroma-core:main Sep 16, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants