Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Get ts-integration-test.sh script working locally #2518

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

AlabasterAxe
Copy link
Contributor

@AlabasterAxe AlabasterAxe commented Jul 15, 2024

Description of changes

  • adds a couple required dependencies for running the JS Tests
  • switches to using pnpm when running the JS client tests
  • adds the .sh extension to the test script
  • suppresses a couple of type errors

Test plan

  • bin/ts-integration-test.sh Passes Running Locally

Documentation Changes

  • N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@AlabasterAxe AlabasterAxe changed the title Get ts-integration-test.sh script working locally [TST] Get ts-integration-test.sh script working locally Jul 15, 2024
@AlabasterAxe
Copy link
Contributor Author

@codetheweb This is a small PR so that these tests run locally.

Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@AlabasterAxe
Copy link
Contributor Author

BTW, I don't have merge access to the repo so I think you'll need to merge my PRs :)

@codetheweb codetheweb merged commit f248fd6 into chroma-core:main Jul 18, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants