Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[ENH] simplify logic for when to persist index changes" #2544

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Revert "[ENH] simplify logic for when to persist index changes" #2544

merged 1 commit into from
Jul 19, 2024

Conversation

codetheweb
Copy link
Contributor

Reverts #2539. Appears that this introduced a bug that can occur after client restart. Will add a (currently) failing test and fix in next PR.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb enabled auto-merge (squash) July 19, 2024 17:49
@codetheweb codetheweb mentioned this pull request Jul 19, 2024
Merged
@codetheweb codetheweb merged commit f879f9e into main Jul 19, 2024
66 checks passed
@codetheweb codetheweb deleted the revert-2539-feat-simplify-persist-trigger branch July 19, 2024 18:36
codetheweb added a commit that referenced this pull request Jul 29, 2024
@codetheweb
[ENH] simplify logic for when to persist index changes (re-apply with…
8907e53 
… fix) (#2545)

History:

- #2539 originally introduced
some of the changes here
- it introduced a bug not caught by our test suite due to limitations of
our suite at the time
- changes were reverted with
#2544
- and now this PR adds a test that [was previously re-producing the
bug](https://github.com/chroma-core/chroma/actions/runs/10012532835/job/27678256604?pr=2545)
before it was fixed here

Should not be merged until hnswlib version is bumped (bug around
persisting a single item was recently fixed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetheweb @HammadB