-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: Yarn package install in getting-started.md #2566
Conversation
change from yarn install to yarn add
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@DuYongLee, thanks for this. |
making a tiny change to retrigger the GH PR checklist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again @DuYongLee
@tazarov Thanks for your checking. it had a conflict so I resolved it. |
@DuYongLee weird github issue where the test suite didnt run (cant merge without it...). - can you bump a commit to this to retrigger them? (add whitespace to a |
bump commit for runner
@jeffchuber I think this issue needs to be approved by tazarov or removed from reviewer. |
Because yarn is installed with add, not install, �I changed yarn install to yarn add.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
It just update for document
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?