Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Tag operators as IO or other + dispatcher schedules IO tasks on the main runtime #2603

Merged
merged 2 commits into from
Aug 1, 2024
Merged

[ENH] Tag operators as IO or other + dispatcher schedules IO tasks on the main runtime #2603

merged 2 commits into from
Aug 1, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jul 31, 2024 •
edited
Loading

Description of changes

Improvements & Bug fixes

  • Only prefetch operator is tagged as IO currently. All others are tagged by default as "Other". Chose "other" instead of CPU as the tag name because these operators do both cpu and io today although we do want to eventually move IO off them.
  • Dispatcher spawns IO tasks on the main tokio runtime.

Test plan

Modified existing rust test

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

This was referenced Jul 31, 2024
Merged
Merged
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Jul 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

@sanketkedia sanketkedia changed the title Tag operators as IO or other and dispatcher handles IO differently [ENH] Tag operators as IO or other + dispatcher schedules IO tasks on the main runtime Jul 31, 2024
@sanketkedia sanketkedia requested a review from HammadB July 31, 2024 07:26
@sanketkedia sanketkedia marked this pull request as ready for review July 31, 2024 07:26
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia force-pushed the 07-31-tag_operators_as_io_or_other_and_dispatcher_handles_io_differently branch from 35b7217 to fdf5a54 Compare July 31, 2024 08:51
@sanketkedia sanketkedia force-pushed the 07-22-dispatch_prefetch_as_operator branch from 225b0b0 to c1fc672 Compare July 31, 2024 14:19
@sanketkedia sanketkedia force-pushed the 07-31-tag_operators_as_io_or_other_and_dispatcher_handles_io_differently branch from fdf5a54 to bf84e8b Compare July 31, 2024 14:19
HammadB
HammadB approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it

@sanketkedia sanketkedia force-pushed the 07-31-tag_operators_as_io_or_other_and_dispatcher_handles_io_differently branch from e087224 to 4fffb81 Compare August 1, 2024 08:52
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Aug 1, 2024 •
edited
Loading

Merge activity

@sanketkedia sanketkedia force-pushed the 07-22-dispatch_prefetch_as_operator branch from 0cda5cd to 52b356d Compare August 1, 2024 10:06
@sanketkedia sanketkedia force-pushed the 07-31-tag_operators_as_io_or_other_and_dispatcher_handles_io_differently branch from 4fffb81 to d34eb72 Compare August 1, 2024 14:28
@sanketkedia sanketkedia changed the base branch from 07-22-dispatch_prefetch_as_operator to main August 1, 2024 14:29
@sanketkedia sanketkedia merged commit c370613 into main Aug 1, 2024
1 check passed
@HammadB HammadB mentioned this pull request Aug 7, 2024
Merged
1 task
HammadB added a commit that referenced this pull request Aug 8, 2024
@HammadB
[PERF] Make pull logs an I/O operator so it runs on main runtime (#2641)
cdd7518 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- This moves pull logs to use the IO operator functionality introduced
in #2603
	 - Renamed IoOperator to IO since its a bit redundant. 
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
Existing tests cover this change
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB