Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] propogate nested error message #2608

Merged
merged 1 commit into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/worker/src/execution/orchestration/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use uuid::Uuid;
pub(super) enum GetHnswSegmentByIdError {
#[error("Hnsw segment with id: {0} not found")]
HnswSegmentNotFound(Uuid),
#[error("Get segments error")]
#[error("Get segments error: {0}")]
GetSegmentsError(#[from] GetSegmentsError),
}

Expand Down Expand Up @@ -100,7 +100,7 @@ pub(super) async fn get_collection_by_id(
pub(super) enum GetRecordSegmentByCollectionIdError {
#[error("Record segment for collection with id: {0} not found")]
RecordSegmentNotFound(Uuid),
#[error("Get segments error")]
#[error("Get segments error: {0}")]
GetSegmentsError(#[from] GetSegmentsError),
}

Expand Down
4 changes: 2 additions & 2 deletions rust/worker/src/execution/orchestration/hnsw.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ enum ExecutionState {
enum HnswSegmentQueryError {
#[error(transparent)]
HnswSegmentQueryError(#[from] super::common::GetHnswSegmentByIdError),
#[error("Get segments error")]
#[error("Get segments error: {0}")]
GetSegmentsError(#[from] GetSegmentsError),
#[error("Collection: {0} not found")]
CollectionNotFound(Uuid),
#[error("Get collection error")]
#[error("Get collection error: {0}")]
GetCollectionError(#[from] GetCollectionsError),
#[error("Record segment not found for collection: {0}")]
RecordSegmentNotFound(Uuid),
Expand Down
4 changes: 2 additions & 2 deletions rust/worker/src/execution/orchestration/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ pub(crate) struct CountQueryOrchestrator {
enum MetadataSegmentQueryError {
#[error("Blockfile metadata segment with id: {0} not found")]
BlockfileMetadataSegmentNotFound(Uuid),
#[error("Get segments error")]
#[error("Get segments error: {0}")]
GetSegmentsError(#[from] GetSegmentsError),
#[error("Record segment not found for collection: {0}")]
RecordSegmentNotFound(Uuid),
Expand All @@ -100,7 +100,7 @@ enum MetadataSegmentQueryError {
SystemTimeError(#[from] std::time::SystemTimeError),
#[error("Collection not found for id: {0}")]
CollectionNotFound(Uuid),
#[error("Get collection error")]
#[error("Get collection error: {0}")]
GetCollectionError(#[from] GetCollectionsError),
}

Expand Down
Loading