Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: only use multipart upload if object size > part size #2622

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

codetheweb
Copy link
Contributor

Description of changes

We observed that using multipart upload for every object put causes enough overhead to cause test failures in CI with existing timeouts, so this PR will bypass multipart upload if the object size is below the part size.

This also bumps the part size to 512MB, as blocks will never be more than 8MB anyways.

Test plan

How are these changes tested?

covered by existing tests, confirmed that both code paths are tested

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

github-actions bot commented Aug 2, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review August 2, 2024 18:42
@codetheweb codetheweb requested a review from HammadB August 2, 2024 18:42
@codetheweb codetheweb force-pushed the fix-only-use-multipart-upload-if-over-part-size branch from b76f668 to 1e4da4c Compare August 2, 2024 19:47
@codetheweb codetheweb enabled auto-merge (squash) August 2, 2024 20:00
@codetheweb codetheweb merged commit a81d3be into main Aug 2, 2024
67 checks passed
@codetheweb codetheweb deleted the fix-only-use-multipart-upload-if-over-part-size branch August 2, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants