-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: use pnpm add <pkg>
instead of pnpm install <pkg>
#2629
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@jferrettiboke weird github issue where the test suite didnt run (cant merge without it...). - can you bump a commit to this to retrigger them? (add whitespace to a |
@jeffchuber I think you have to click on "Approve and run". |
@jferrettiboke, the PR title check fails. Can you do me a favor and update the title to start with |
pnpm add <pkg>
instead of pnpm install <pkg>
pnpm add <pkg>
instead of pnpm install <pkg>
@tazarov Done. ✅ |
Thanks @jferrettiboke, looks good in CI now |
It should be
pnpm add <pkg>
instead ofpnpm install <pkg>
.pnpm install
is used to install all dependencies for a project whilepnpm add <pkg>
is used to install a package and any packages that it depends on.More info (official source):
pnpm install <pkg>
does the same aspnpm add <pkg>
today, but it might stop functioning that way in future versions since the official docs clarify the difference between the two. It might be thatpnpm install <pkg>
was used in past versions, and the PNPM team didn't want to remove support for it right away after introducingpnpm add <pkg>
.