Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] NAC rate limits requests #2632

Merged
merged 3 commits into from
Aug 20, 2024
Merged

[ENH] NAC rate limits requests #2632

merged 3 commits into from
Aug 20, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Aug 4, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Introduced count based rate limiting policy where a maximum of X number of outstanding are permitted. X is configurable.

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

github-actions bot commented Aug 4, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link

github-actions bot commented Aug 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

sanketkedia commented Aug 4, 2024

@sanketkedia sanketkedia changed the title Rate limit for NAC [ENH] NAC rate limits requests Aug 4, 2024
@sanketkedia sanketkedia marked this pull request as ready for review August 4, 2024 10:46
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@sanketkedia sanketkedia changed the base branch from 08-03-consume_nac to graphite-base/2632 August 20, 2024 00:18
@sanketkedia sanketkedia changed the base branch from graphite-base/2632 to main August 20, 2024 00:18
@sanketkedia sanketkedia merged commit a886630 into main Aug 20, 2024
132 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants