Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: allow using node selectors for pods instead of tolerations #2672

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Aug 16, 2024

Description of changes

We want to bind pods to nodes, instead of disallowing other pods from being scheduled on specific nodes.

Test plan

How are these changes tested?

Tested locally with Tilt.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the fix-use-labels-instead-of-taints branch from f8c592a to 378178e Compare August 16, 2024 00:19
@codetheweb codetheweb marked this pull request as ready for review August 16, 2024 00:22
@codetheweb codetheweb enabled auto-merge (squash) August 16, 2024 00:22
@codetheweb codetheweb merged commit 9a64d93 into main Aug 16, 2024
67 checks passed
@codetheweb codetheweb deleted the fix-use-labels-instead-of-taints branch August 16, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant