Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Move write to blockfiles off main runtime #2740

Merged
merged 2 commits into from
Aug 29, 2024
Merged

[PERF] Move write to blockfiles off main runtime #2740

merged 2 commits into from
Aug 29, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Aug 29, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • write_to_blockfiles is an intense operation, there should be no reason to hog the main runtime. Moved it to a worker thread as part of flush operation. I am hesitant to create a new operator exclusively for this as all of this seems temporary and eventually we want the blockfile to support read then write semantics

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia changed the title Move write to blockfiles off main runtime [PERF] Move write to blockfiles off main runtime Aug 29, 2024
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

@sanketkedia sanketkedia marked this pull request as ready for review August 29, 2024 19:27
@sanketkedia sanketkedia merged commit 8b565ad into main Aug 29, 2024
66 of 68 checks passed
spikechroma pushed a commit that referenced this pull request Sep 12, 2024
@sanketkedia @spikechroma
[PERF] Move write to blockfiles off main runtime (#2740)
81534fb 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- write_to_blockfiles is an intense operation, there should be no reason
to hog the main runtime. Moved it to a worker thread as part of flush
operation. I am hesitant to create a new operator exclusively for this
as all of this seems temporary and eventually we want the blockfile to
support read then write semantics

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB