Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF]: speed up get_target_block_id() #2743

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Aug 29, 2024

Description of changes

Fixes get_target_block_id() to run in O(log n) instead of O(n). Shaves around 2.6s off total compaction time for 26k documents.

get-target-block-id.trace.zip

Test plan

How are these changes tested?

Covered by existing tests.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator

HammadB commented Aug 29, 2024

nice, good change. @sanketkedia can you TAL as well?

@codetheweb codetheweb force-pushed the feat-faster-get-target-block-id branch from 7adb189 to b7aaed8 Compare August 30, 2024 00:10
Copy link
Contributor

@sanketkedia sanketkedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Thank you!

@codetheweb codetheweb merged commit 2be7727 into main Sep 3, 2024
67 checks passed
@codetheweb codetheweb deleted the feat-faster-get-target-block-id branch September 3, 2024 16:48
spikechroma pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants