[ENH] Support >= numpy 2.0 #2776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikechroma and the rest of your teammates on |
|
Were you able to test this / confirm that onnxruntime released a supporting version to Pypi? |
spikechroma
changed the title
this is still in wip. let me test it today |
spikechroma
force-pushed
the
spike/remove_numpy_version_lock
branch
from
b736380
to
bc99fdd
Compare
|
Mac and Windows test passing for the |
spikechroma
changed the title
|
Closing in favor of #2811 |
HammadB
added a commit
that referenced
this pull request
Sep 17, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Supports numpy 2.0 now that onnxruntime supports it by removing our limit of <2.0 - Change usage of `float_` to `float64`. These are supported in both < and >= 2.0. However `float_` is only supported by < 2.0. In < 2.0 the _ types are shorthand for the 64bit wide datatypes. I verified this. This makes the changes cleaner than #2776. <img width="300" alt="Screenshot 2024-09-17 at 10 15 21 AM" src="https://github.com/user-attachments/assets/8e290733-419c-4d3c-9d71-dc76d01618d7"> - New functionality - None ## Test plan *How are these changes tested?* Existing tests - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?