[CLN] Propagate errors for block get/fork #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
sanketkedia
reviewed
Sep 11, 2024
| impl ChromaError for BlockLoadError { | ||
| fn code(&self) -> ErrorCodes { | ||
| match self { | ||
| BlockLoadError::IOError(_) => ErrorCodes::Internal, |
There was a problem hiding this comment.
note to self and others: Almost all of our codebase is littered with ErrorCodes::Internal, maybe evaluate if they can convey more than that?
sanketkedia
reviewed
Sep 11, 2024
| @@ -319,11 +354,14 @@ impl<'me, K: ArrowReadableKey<'me> + Into<KeyWrapper>, V: ArrowReadableValue<'me | |||
| let target_block_id = self.sparse_index.get_target_block_id(&search_key); | |||
There was a problem hiding this comment.
I added a task in tracker to remove Box<dyn ChromaError> and instead add specific error types
sanketkedia
approved these changes
Sep 11, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - ... - New functionality - ... ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
This PR also contains stacked PRs as part of mereg
#2780
#2793
Test plan
How are these changes tested?
Non functional changes. Existing tests. We should add tests for these cases
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None