Merge pull request #1094 from chromaui/jmhobbs/cap-2266-misleading-er…

…ror-during-downtime

Add context to sentinel upload failures.

node-src/tasks/upload.ts

@@ -14,6 +14,7 @@ import { rewriteErrorMessage, throttle } from '../lib/utils';
 import { waitForSentinel } from '../lib/waitForSentinel';
 import { Context, FileDesc, Task } from '../types';
 import missingStatsFile from '../ui/messages/errors/missingStatsFile';
+import sentinelFileErrors from '../ui/messages/errors/sentinelFileErrors';
 import bailFile from '../ui/messages/warnings/bailFile';
 import deviatingOutputDirectory from '../ui/messages/warnings/deviatingOutputDirectory';
 import {
@@ -274,7 +275,12 @@ export const waitForSentinels = async (ctx: Context, task: Task) => {
     })
   );
 
-  await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
+  try {
+    await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
+  } catch (err) {
+    ctx.log.error(sentinelFileErrors());
+    throw err;
+  }
 };
 
 export default createTask({

node-src/ui/messages/errors/sentinelFileErrors.stories.ts

@@ -0,0 +1,7 @@
+import sentinelFileErrors from './sentinelFileErrors';
+
+export default {
+  title: 'CLI/Messages/Errors',
+};
+
+export const SentinelFileErrors = () => sentinelFileErrors();

node-src/ui/messages/errors/sentinelFileErrors.ts

@@ -0,0 +1,10 @@
+import chalk from 'chalk';
+import { dedent } from 'ts-dedent';
+
+import { error } from '../../components/icons';
+import link from '../../components/link';
+
+export default () =>
+  dedent(chalk`
+    ${error} Failed to finalize upload. Please check ${link('https://status.chromatic.com/')} or contact support.
+  `);