Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Releases #1084

Merged
merged 11 commits into from
Oct 8, 2024
Merged

Add Sentry Releases #1084

merged 11 commits into from
Oct 8, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 7, 2024

Adds sourcemaps and releases to Sentry:

  • Has tsup build with sourcemaps
  • Uses tsup environment variable substitution on SENTRY_RELEASE to add to init
  • Uses @sentry/cli to upload sourcemaps and create the release
  • Removes the sourcemaps so they don't get bundled into the distribution
  • Continues with the auto release flow
📦 Published PR as canary version: 11.12.1--canary.1084.11238719287.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link
Contributor

github-actions bot commented Oct 7, 2024

📦 Package Size: 5268 KB
✅ Compared to main: 0 KB d642d22 (5268 KB)

Copy link

codacy-production bot commented Oct 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.15% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d642d22) 8639 4652 53.85%
Head commit (22b76e8) 8460 (-179) 4653 (+1) 55.00% (+1.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1084) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch from 2df96df to 911f435 Compare October 7, 2024 19:50
@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Oct 7, 2024
@jmhobbs
Copy link
Contributor Author

jmhobbs commented Oct 7, 2024

Version baked into the Sentry.init in bin.js of the canary:

Screenshot 2024-10-07 at 2 57 39 PM

Same version from the CLI flag to confirm that works:

Screenshot 2024-10-07 at 2 58 09 PM

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch 3 times, most recently from c19a0e9 to 7b85bd3 Compare October 7, 2024 20:52
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch from 7b85bd3 to 8b65297 Compare October 7, 2024 20:58
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch 2 times, most recently from 2ea094b to 73c8526 Compare October 7, 2024 21:49
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch from 73c8526 to d017d10 Compare October 7, 2024 21:55
@jmhobbs jmhobbs requested a review from a team October 7, 2024 21:59
@jmhobbs jmhobbs self-assigned this Oct 7, 2024
@jmhobbs jmhobbs marked this pull request as ready for review October 7, 2024 21:59
.github/workflows/package-size-main.yml Outdated Show resolved Hide resolved
.github/workflows/package-size.yml Outdated Show resolved Hide resolved
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2192-add-releases branch from 7846860 to 22b76e8 Compare October 8, 2024 15:04
@jmhobbs jmhobbs added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Oct 8, 2024
@jmhobbs
Copy link
Contributor Author

jmhobbs commented Oct 8, 2024

Merging over lint-and-test as that PR is still open and we are covered by the CircleCI version.

@jmhobbs jmhobbs merged commit be33c60 into main Oct 8, 2024
24 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2192-add-releases branch October 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants