Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GITHUB_REF check on release #1093

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix GITHUB_REF check on release #1093

merged 1 commit into from
Oct 10, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 9, 2024

According to https://github.blog/changelog/2023-09-13-github-actions-updates-to-github_ref-and-github-ref/ we now need to check for refs/heads/main, not main.

📦 Published PR as canary version: 11.12.7--canary.1093.11388111142.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Oct 9, 2024
@jmhobbs jmhobbs requested a review from codykaup October 9, 2024 20:35
@jmhobbs jmhobbs self-assigned this Oct 9, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1f132171 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1f13217) Report Missing Report Missing Report Missing
Head commit (3953912) 8460 4652 54.99%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1093) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

📦 Package Size: 5268 KB

@jmhobbs jmhobbs added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 6890d08 Oct 10, 2024
25 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/action-deploy branch October 10, 2024 16:18
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.12.6 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants