Ensure parent directory exists before writing log/diagnostics file #1117
+42
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codykaup
added
release
|
📦 Package Size: 5380 KB |
codykaup
force-pushed
the
cody/cap-2375-chromatic-cli-fails-to-create-directory-paths-for-log-files
branch
from
92c9481
to
0b40fff
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
codykaup
force-pushed
the
cody/cap-2375-chromatic-cli-fails-to-create-directory-paths-for-log-files
branch
from
0b40fff
to
6cd81a7
Compare
jmhobbs
approved these changes
Nov 4, 2024
codykaup
deleted the
cody/cap-2375-chromatic-cli-fails-to-create-directory-paths-for-log-files
branch
|
🚀 PR was released in |
chromatic-ci-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to send
--log-fileand--diagnostics-fileto a random location that doesn't exist yet. In those cases, we were throwing aENOENTerror when attempting to write to the stream. This ensures the parent directory exists before we attempt to write those files!📦 Published PR as canary version:
11.16.5--canary.1117.11667960642.0✨ Test out this PR locally via: