-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate and record uncommittedHash
when creating a build
#798
Calculate and record uncommittedHash
when creating a build
#798
Conversation
AP-3369 Add concept of outdated builds
To get a hash of staged+unstaged+untracked changes:
This seems to be the only way to get a full hash of all these types of changes, whilst excluding any deleted files (which would cause an error because they can't be hashed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
It looks like this is failing tests because the CI for multiple reasons. Action-canary is a git.email issue others are 400 errors from git |
That's caused by this PR which is released as canary but not merged yet. It needs to deal with missing email config. The unit tests fail due to missing mock for getUncommittedHash. I added those just now. The other tests fail because the index doesn't accept |
This is required for the "is outdated" concept in the Visual Tests addon, but may also be used in the future for other builds (e.g. during onboarding or even CI builds with an unclean working directory).