Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projectId + userToken as alternative to projectToken for auth #852

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 6, 2023

Fixes AP-3383

Depends on https://github.com/chromaui/chromatic/pull/7913

This adds support for authentication via projectId and userToken, as an alternative to passing a projectToken. Currently only via the Node API (not as a flag).

This uses a new mutation createCLIToken on the public API to generate an "app token" that's compatible with the app token we'd otherwise get through the existing createAppToken mutation.

📦 Published PR as canary version: 7.6.1--canary.852.6771374764.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged security Classification: Security-related updates minor Auto: Increment the minor version when merged labels Nov 7, 2023
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghengeveld ghengeveld added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit f2a52aa Nov 10, 2023
26 of 27 checks passed
@ghengeveld ghengeveld deleted the support-oauth-token branch November 10, 2023 14:39
@ghengeveld
Copy link
Member Author

🚀 PR was released in v9.0.0 🚀

@ghengeveld ghengeveld added the prerelease Verdict: This change is available in a prerelease label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged prerelease Verdict: This change is available in a prerelease release Auto: Create a `latest` release when merged security Classification: Security-related updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants