Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use code splitting in tsup CJS output #873

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Use code splitting in tsup CJS output #873

merged 2 commits into from
Dec 14, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 11, 2023 •
edited by ghengeveld
Loading

So we can share code between dist/bin.js and dist/node.js.

Before:

CJS dist/node.js 3.80 MB
CJS dist/bin.js  3.82 MB

After:

CJS dist/multipart-parser-5IFH23I5.js 4.41 KB
CJS dist/bin.js                       3.82 KB
CJS dist/node.js                      597.00 B
CJS dist/chunk-KXSLPKCE.js            60.17 KB
CJS dist/chunk-4SA3TPUB.js            3.79 MB
📦 Published PR as canary version: 10.1.1--canary.873.7163392853.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@tmeasday
Use code splitting in tsup CJS output
c6ce822 
So we can share code between `dist/bin.js` and `dist/node.js`
@tmeasday tmeasday added patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Dec 13, 2023
@tmeasday tmeasday added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 2ef8f4b Dec 14, 2023
17 of 19 checks passed
@tmeasday tmeasday deleted the tom/split-dist-output branch December 14, 2023 04:33
@ghengeveld
Copy link
Member

🚀 PR was released in v10.2.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @ghengeveld