-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace getUploadUrls
with uploadBuild
mutation
#876
Replace getUploadUrls
with uploadBuild
mutation
#876
Conversation
…Url/isolatorUrl references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm unsure exactly why we need two mutations however, why is the metadata separated from the build data (if it ends up in the same place)?
Because the metadata (CLI logs and such) is collected at the very end of the CLI process (when the build might've already finished). I suppose we could send part of the metadata along with the build upload itself (e.g. config files) but that would complicate things. |
…durls-with-uploadbuild-mutation
I am not able to run a build using the suggested command in the description. I have tried multiple projects, both existing and new, but the build always fails at the Storybook verifying step, just specifying that there was a failure to extract the Storybook. I also noticed that all of the smoke tests in this PR are failing, so I decided not to dig too far into the problems I'm seeing locally. |
@andrewortwein Sorry, I was using my local version rather than the canary, so I hadn't noticed the canary was very old and not updating anymore. That turned out to be due to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🆕👍🏻
🚀 PR was released in |
Depends on https://github.com/chromaui/chromatic/pull/8049
This uses the new
uploadBuild
mutation which uses S3 presigned POST requests for uploading and enforces strict file size limitations.The mutation no longer returns the storybook base domain, instead we query for
storybookUrl
on the build. All references tocachedUrl
andisolatorUrl
have been replaced withstorybookUrl
.📦 Published PR as canary version:
10.1.1--canary.876.7220703629.0
✨ Test out this PR locally via: