Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configFile option to GitHub Action #885

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add configFile option to GitHub Action #885

merged 1 commit into from
Jan 12, 2024

Conversation

wisestuart
Copy link
Contributor

@wisestuart wisestuart commented Jan 11, 2024 •
edited
Loading

The Chromatic CLI can receive a --config-file configuration option.

This change exposes that same option in the GitHub action.

@wisestuart wisestuart changed the title feat: add configFile input to action Add configFile option to GitHub Action Jan 11, 2024
@JonathanKolnik
Copy link
Contributor

Hey @wisestuart, appreciate you catching this and taking the time to sort it out. We should have this released soon!

@JonathanKolnik JonathanKolnik mentioned this pull request Jan 12, 2024
Closed
JonathanKolnik
JonathanKolnik approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@JonathanKolnik JonathanKolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@JonathanKolnik JonathanKolnik added this pull request to the merge queue Jan 12, 2024
Merged via the queue into chromaui:main with commit 3fc494e Jan 12, 2024
19 of 24 checks passed
@ghengeveld
Copy link
Member

🚀 PR was released in v10.2.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jan 12, 2024
@wisestuart wisestuart deleted the config-file-in-gha branch January 15, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanKolnik JonathanKolnik JonathanKolnik approved these changes

Assignees
No one assigned
Labels
released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wisestuart @JonathanKolnik @ghengeveld