Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging around upload errors #894

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Improve logging around upload errors #894

merged 5 commits into from
Jan 25, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jan 18, 2024 •
edited
Loading

Logging file upload errors was basically broken because it didn't properly report back the file name. That's fixed now and I also added this extra info message that attempts to diagnose the problem based on a simple heuristic (does url encoding change the file path at all):

✖ Failed to upload path/to/whoop$.jpg to whoop$.jpg
It seems the file path may contain illegal characters.
Enable the debug option to get more information.
📦 Published PR as canary version: 10.5.2--canary.894.7656791058.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld added the patch Auto: Increment the patch version when merged label Jan 25, 2024
andrewortwein
andrewortwein approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵👍🏻

@ghengeveld ghengeveld added the skip-release Auto: Preserve the current version when merged label Jan 25, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 2aeadd2 Jan 25, 2024
19 checks passed
@ghengeveld ghengeveld deleted the improve-upload-logging branch January 25, 2024 15:24
@ghengeveld
Copy link
Member Author

🚀 PR was released in v10.5.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewortwein andrewortwein andrewortwein approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @andrewortwein