Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for boolean value to junitReport option #937

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix support for boolean value to junitReport option #937

merged 2 commits into from
Mar 5, 2024

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Mar 5, 2024 •
edited by ghengeveld
Loading

This PR adds the functionality to generate the JUnit report with the default naming scheme if the flag is set to true.

To QA

  1. Run npx [email protected] -t=PROJECT_TOKEN --junit-report=true
  2. Run the Unit tests.
📦 Published PR as canary version: 11.0.3--canary.937.8162574426.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@thafryer thafryer added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 5, 2024
ghengeveld
ghengeveld approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK 👍

@ghengeveld ghengeveld changed the title Generate JUnit report with Default Naming scheme Support boolean flag for junitReport option Mar 5, 2024
@ghengeveld ghengeveld changed the title Support boolean flag for junitReport option Fix support for boolean value to junitReport option Mar 5, 2024
@thafryer thafryer added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@JonathanKolnik JonathanKolnik added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@thafryer thafryer added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 30bc7c4 Mar 5, 2024
19 checks passed
@thafryer thafryer deleted the jarel/ap-4316-cli-exits-unexpectedly-when-junitreport-true-is-in-my-config branch March 5, 2024 20:24
@ghengeveld
Copy link
Member

🚀 PR was released in v11.0.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 5, 2024
@andrewortwein andrewortwein linked an issue Mar 6, 2024 that may be closed by this pull request
Specifying junitReport: true makes chromatic crash when reporting build status #935
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanKolnik JonathanKolnik JonathanKolnik approved these changes

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifying junitReport: true makes chromatic crash when reporting build status
3 participants
@thafryer @ghengeveld @JonathanKolnik