Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.60 #1347

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Bump MSRV to 1.60 #1347

merged 1 commit into from
Nov 7, 2023

Conversation

djc
Copy link
Member

@djc djc commented Oct 30, 2023

Fixes #1344, I think.

@djc djc requested a review from pitdicker October 30, 2023 08:30
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1347 (08ca3aa) into 0.4.x (02bdd1d) will increase coverage by 0.01%.
Report is 1 commits behind head on 0.4.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1347      +/-   ##
==========================================
+ Coverage   91.60%   91.61%   +0.01%     
==========================================
  Files          38       38              
  Lines       17430    17482      +52     
==========================================
+ Hits        15966    16016      +50     
- Misses       1464     1466       +2     
Files Coverage Δ
src/lib.rs 95.58% <ø> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker
Copy link
Collaborator

Sorry I have been absent, I'll have a look tomorrow.

@djc
Copy link
Member Author

djc commented Nov 1, 2023

@pitdicker no worries! Friendly ping?

@pitdicker
Copy link
Collaborator

I am trying to understand the cause of the dependency resolution issue on 1.57.0. It seems to be because ahash 0.7.6 is yanked last week. We used to have 0.7.6 in the dependency tree.

All versions before 0.7.7 have a vulnerability and are yanked: tkaitchuck/aHash#163, fixed in PR tkaitchuck/aHash#175.
But it also pulls in a fix for AVR that updates once_cell to 1.13.1.

Maybe we should get in contact in tkaitchuck/aHash#174 or some other issue before bumping the MSRV?

@djc
Copy link
Member Author

djc commented Nov 1, 2023

I think it's probably because the latest ahash 0.7 release includes use of specific dep: features, which cause Cargo before 1.60 to fail parsing the manifest (but I didn't actually check).

@djc
Copy link
Member Author

djc commented Nov 1, 2023

I feel like it's okay to get to 1.60 at this point. Current Debian stable has 1.63.

@pitdicker
Copy link
Collaborator

Okay, I'm the last to complain about bumping the MSRV 😄. and Debian is pretty much the one to care about, right?

Do you also want to update the documentation in README.md and lib.rs?

@pitdicker
Copy link
Collaborator

If we bump to 1.61 we can start making the methods on DateTime const, and remove the workaround from 6b3a314.

@djc
Copy link
Member Author

djc commented Nov 1, 2023

Added the README and crate root docs changes and bumped to 1.61.

@djc
Copy link
Member Author

djc commented Nov 7, 2023

@pitdicker ping?

Copy link
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, in my memory this was already merged.

@pitdicker pitdicker merged commit dd3f2f8 into 0.4.x Nov 7, 2023
37 checks passed
@pitdicker pitdicker deleted the msrv-1.60 branch November 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants