Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restart download upon moving unless it's necessary #118

Closed
chros73 opened this issue Aug 3, 2017 · 1 comment
Closed

Don't restart download upon moving unless it's necessary #118

chros73 opened this issue Aug 3, 2017 · 1 comment
Labels
enhancement important
Milestone
0.9.8-0.9.7

Comments

@chros73
Copy link
Owner

chros73 commented Aug 3, 2017 •
edited
Loading

A download only must be restarted upon moving when when it's hashckecked or manually moved.

Moving a download happens:

  • automatically
    • when a download is finished: d.stop= isn't necessary
    • when a dropped in download finished hashchecking: d.stop= is necessary
  • manually:
    • complete restart not really necessary (changing throttle groups requires it), but it doesn't hurt, since d.directory.set= will loose our peers for a moment
@chros73 chros73 added this to the 0.9.8-0.9.7 milestone Aug 3, 2017
@chros73 chros73 removed this from the 0.9.8-0.9.7 milestone Aug 6, 2017
@chros73
Copy link
Owner Author

chros73 commented Aug 6, 2017 •
edited
Loading

Archive:
A download only must be restarted upon moving when its d.throttle_name property is changed.

Moving a download happens:

  • automatically (when a download is finished): restart isn't necessary
  • manually:
    • only restart it if it changes its group (special, main)

As it turned out, when data moving happens, rtorrent always stops and closes the download:

  • d.directory.set= has to be used: it calls Download::set_root_directory(const std::string& path)
  • there's no way to do anything about it

@chros73 chros73 closed this as completed Aug 6, 2017
@chros73 chros73 added this to the 0.9.8-0.9.7 milestone Aug 7, 2017
chros73 pushed a commit that referenced this issue Aug 7, 2017
Don't restart download upon moving unless it's necessary (Closes #118)
33ba9f6
@chros73 chros73 reopened this Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement important
Projects
None yet
Milestone
0.9.8-0.9.7
Development

No branches or pull requests
1 participant
@chros73