Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added typescript definition, corrected README #10

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Added typescript definition, corrected README #10

merged 4 commits into from
Dec 13, 2020

Conversation

pascalopitz
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 21, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 95.779% when pulling cfcaf20 on pascalopitz:master into 99bbf70 on chrvadala:master.

@pascalopitz pascalopitz force-pushed the master branch 2 times, most recently from bc044a7 to 18461f5 Compare June 21, 2020 05:34
chrvadala
chrvadala requested changes Jun 21, 2020
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR. below some comments

@pascalopitz
Copy link
Contributor Author

No worries. Good work on the lib, works a treat!

@chrvadala
Copy link
Owner

Thank you, I'll merge soon

@chrvadala chrvadala self-assigned this Jun 21, 2020
@Sunoo
Copy link
Contributor

Sunoo commented Aug 30, 2020

Just a quick note, spotted a few mismatches between this type definition and the library, and I corrected them in a pull request on that fork: pascalopitz#1

Might make sense to look into that before merging.

@jordanorc
Copy link

Any update on that?

@chrvadala chrvadala merged commit a12407a into chrvadala:master Dec 13, 2020
@chrvadala
Copy link
Owner

Released with v1.3.0
Thanks @pascalopitz for the PR

@jordanorc
Copy link

Thank's @chrvadala and @pascalopitz! Great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrvadala chrvadala chrvadala approved these changes

Assignees

@chrvadala chrvadala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pascalopitz @coveralls @chrvadala @Sunoo @jordanorc