Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout and discoveryInterval optional parameters Adapter.waitDevice in index.d.ts #48

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

mxc42
Copy link
Contributor

@mxc42 mxc42 commented Nov 8, 2022

Adapter.waitDevice supports two optional parameters in the docs, however these don't appear in the index.d.ts file, making them unusable in Typescript. I've added them here.

Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I'll merge in the following days

@chrvadala chrvadala merged commit 78ebe01 into chrvadala:main Nov 12, 2022
@chrvadala
Copy link
Owner

I released this PR with 1.9.0 and I added your name into contributions list.
Thanks @mxc42 for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants