Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: forward "unproven" feature dependency #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucab
Copy link

@lucab lucab commented Oct 26, 2019

This forwards the "unproven" feature from this crate to the
corresponding feature on dependencies.

This forwards the "unproven" feature from this crate to the
corresponding feature on dependencies.
@chrysn
Copy link
Owner

chrysn commented Mar 24, 2020

Building this with --features chip-efm32gg --no-default-features, I get

error[E0405]: cannot find trait `InputPin` in module `digital`
  --> src/gpio.rs:45:26
   |
45 |     type Input: digital::InputPin;
   |                          ^^^^^^^^ not found in `digital`

Was this maybe tested with an increased embedded-hal version? If so, that should be bumped in the PR.

@lucab
Copy link
Author

lucab commented Mar 25, 2020

@chrysn thanks for the feedback! No, there seems to be more places that are missing the #[cfg(feature = "unproven")] annotation, so the codebase needs to be massaged further.

Anyway, this PR got stale in the meanwhile and embedded-hal is dropping the whole unproven feature, see rust-embedded/embedded-hal#192.

I'd suggest to abandon this PR, and instead:

  • bump the embedded-hal dependency to 0.2.3
  • drop all the not(feature = "unproven") annotations, i.e. always require unproven
  • switch to digital v2/fallible traits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants