Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'tool install' command #57

Closed
chshersh opened this issue Aug 31, 2022 · 0 comments · Fixed by #89
Closed

Implement the 'tool install' command #57

chshersh opened this issue Aug 31, 2022 · 0 comments · Fixed by #89
Assignees
@chshersh @MitchellBerend
Labels
CLI Command Line Interface enhancement New feature or request
Milestone
v0.2.0: Improved ...

Comments

@chshersh
Copy link
Owner

chshersh commented Aug 31, 2022 •
edited
Loading

This command can install a single tool from the repo and update the default configuration as well.

In the first version of this command, it should only support the installation of known tools with the command like:

$ tool install bat

If the tool is unknown, it should print the error message:

$ tool install xxx
Unknown tool: 'xxx'
Supported tools:
    * bat
    * ripgrep
    * ...

The specific behaviour:

  1. Check if the tool is known.
  2. If yes, try syncing the tool.
@chshersh chshersh added the enhancement New feature or request label Aug 31, 2022
@chshersh chshersh added this to the v0.2.0: Improved sync milestone Aug 31, 2022
@chshersh chshersh self-assigned this Sep 3, 2022
@chshersh chshersh pinned this issue Sep 3, 2022
@chshersh chshersh added the CLI Command Line Interface label Sep 3, 2022
@chshersh chshersh unpinned this issue Sep 15, 2022
@MitchellBerend MitchellBerend mentioned this issue Sep 15, 2022
Merged
2 tasks
chshersh pushed a commit that referenced this issue Sep 15, 2022
@MitchellBerend
[#57] Adds install command to install known tools (#89)
2bb99cf 
Resolves #57 

This pr adds an `isntall` subcommand that lets the user install any of
the hardcoded tools. As a bonus it also implements the `From` trait to
convert from `ToolInfo` To `ConfigAsset`.

### Additional tasks

- [x] Documentation for changes provided/changed
- [x] Tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

@MitchellBerend MitchellBerend

Labels
CLI Command Line Interface enhancement New feature or request
Projects
None yet
Milestone
v0.2.0: Improved sync + install
Development

Successfully merging a pull request may close this issue.

[#57] Adds install command to install known tools MitchellBerend/tool-sync
2 participants
@chshersh @MitchellBerend