[#32] Add tag option to download a specific tool version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancisMurillo
force-pushed
the
feature/specific-tag
branch
from
cb9e4f4
to
e3bafd9
Compare
chshersh
added
enhancement
chshersh
requested changes
Sep 3, 2022
Comment on lines
+125
to
+126
| # uncomment to download a specific version or tag | ||
| # tag = "12.1.1" |
There was a problem hiding this comment.
Thanks for updating the documentation as well! 👏🏻
src/config/toml.rs
Outdated
| @@ -275,6 +281,7 @@ mod tests { | |||
| macos: Some("C3-PO".to_owned()), | |||
| windows: Some("IG-88".to_owned()), | |||
| }, | |||
| tag: None, | |||
There was a problem hiding this comment.
The test single_full_tool checks all the fields in a single TOML table of a tool. So let's add tag to the TOML text and expect Some(...) in this last test
src/sync/configure.rs
Outdated
| let tag = config_asset | ||
| .tag | ||
| .clone() | ||
| .map(|version| ToolInfoTag::Specific(version)) |
There was a problem hiding this comment.
I'm not sure but I believe this simplification should compile 🤔
Suggested change
| .map(|version| ToolInfoTag::Specific(version)) | |
| .map(ToolInfoTag::Specific) |
| @@ -257,7 +277,8 @@ mod tests { | |||
| linux: Some("my-linux".to_string()), | |||
| macos: Some("my-macos".to_string()), | |||
| windows: Some("yours-windows".to_string()), | |||
| } | |||
| }, | |||
| tag: ToolInfoTag::Specific("3.2.1".to_string()), | |||
There was a problem hiding this comment.
Really appreciate updated tests 🙏🏻
src/sync/download.rs
Outdated
Comment on lines
28
to
41
| if let Some(tag) = self.specific_tag { | ||
| format!( | ||
| "https://api.github.com/repos/{owner}/{repo}/releases/tags/{tag}", | ||
| owner = self.owner, | ||
| repo = self.repo, | ||
| tag = tag, | ||
| ) | ||
| } else { | ||
| format!( | ||
| "https://api.github.com/repos/{owner}/{repo}/releases/latest", | ||
| owner = self.owner, | ||
| repo = self.repo, | ||
| ) | ||
| } |
There was a problem hiding this comment.
I propose a slight simplification to this logic. Let's rename as_specific_tag to to_str_version and make this function return String.
This way, this formatting could be just:
format!(
"https://api.github.com/repos/{owner}/{repo}/releases/{version}",
owner = self.owner,
repo = self.repo,
version = tag.to_str_version(),
)
chshersh
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should resolve #32 which just adds
tagoption to specify which version of the tool to download. If omitted it will default to the latest release.