-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#52] Adds a generate command for a default .tools.toml file #62
[#52] Adds a generate command for a default .tools.toml file #62
Conversation
…commented out as a template
We should wait for the discussion in #65 to be resolved since this issue might constitute changes in this pr |
…ation for the tag attribute
The file that currently gets generated looks like this $ cat test-tools.toml
# This file was automatically generated by tool-sync
#
# The directory to store all tools in
#store_directory = "$HOME/.local/bin"
#
#[ripgrep]
# owner = "BurntSushi"
# repo = "ripgrep"
# exe_name = "rg"
#
# # Uncomment to download a specific version or tag.
# # Without this tag latest will be used
# # tag = "latest"
#
#
# Asset name to download on linux OSes
#asset_name.linux = "x86_64-unknown-linux-musl"
#
# uncomment if you want to install on macOS as well
#asset_name.macos = "apple-darwin"
#
# uncomment if you want to install on Windows as well
#asset_name.windows = "x86_64-pc-windows-msvc" Is this missing anything? |
…with the tool itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change 🏆
I feel like the design space for this innocently-looking option is too big so I'd like to have a conversation. But good defaults matter 👏🏻 So I want users to have the best UX.
…tself to hold more information
…o stdout to play nice with the unix philosophy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment and this PR is ready to go 👍🏻
Really appreciate your work here, @MitchellBerend 👏🏻
The more I think about this, the more ideas and feature requests I can come up with. But let's take time and settle on some design and refine it later.
Issues that can be created following this pr
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton!
@MitchellBerend These new issues look like a good improvement over the existing state of affairs 👍🏻 |
I've created an issue to discuss the future interface of all config-related commands: |
Resolves #52.
The generate command also uses the --config flag to set the location of the generated file. Would it be a good idea to have some output when actually generating the config? Right now there is no actual response unless there is some file system error.