Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#63] Added tag support in download progress #64

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

MitchellBerend
Copy link
Collaborator

Resolves #63

Added a max_tag_size on SyncProgress to prepare the output message for tags
that are longer than normal.

$ cargo run -- --config test-tools.toml sync
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/tool --config test-tools.toml sync`
⛔  bat     asdkjhkasdjfaksjdfhk;j [error] https://api.github.com/repos/sharkdp/bat/releases/tags/asdkjhkasdjfaksjdfhk;j: status code 404
✅  exa     v0.10.1                Completed!
✅  fd      v8.4.0                 Completed!
✅  ripgrep 13.0.0                 Completed!


$ cat test-tools.toml 
# This file was automatically generated by tool-sync
#
store_directory = "./bins"

    [bat]
        owner =     "sharkdp"
        repo =      "bat"
        exe_name =  "bat"
        tag =       "asdkjhkasdjfaksjdfhk;j"
    [exa]
        owner =     "ogham"
        repo =      "exa"
        exe_name =  "exa"
        tag =       "v0.10.1"
    [fd]
        owner =     "sharkdp"
        repo =      "fd"
        exe_name =  "fd"
        tag =       "v8.4.0"
    [ripgrep]
        owner =     "BurntSushi"
        repo =      "ripgrep"
        exe_name =  "rg"
        tag =       "13.0.0"

@chshersh chshersh added output Fancy (and not so) output of the tool enhancement New feature or request labels Sep 5, 2022
@chshersh chshersh changed the title added tag support in download progress [#63] Added tag support in download progress Sep 5, 2022
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and simple improvement 👍🏻

I have a few suggestions for improving the code but the overall it looks great 👏🏻

src/sync.rs Show resolved Hide resolved
src/sync/progress.rs Outdated Show resolved Hide resolved
src/sync/progress.rs Show resolved Hide resolved
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing 👏🏻

@chshersh chshersh merged commit eeed4bb into chshersh:main Sep 7, 2022
@MitchellBerend MitchellBerend deleted the 63-tag-output-on-download branch September 8, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request output Fancy (and not so) output of the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding tag support in download progress output
2 participants