-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#87] Use statically linked binaries for linux #95
[#87] Use statically linked binaries for linux #95
Conversation
I checked that the binary is indeed statically linked: ~/Downloads/tool-x86_64-unknown-linux-musl$ ldd tool
statically linked
~/Downloads/tool-x86_64-unknown-linux-gnu$ ldd tool
linux-vdso.so.1 (0x00007fffb8469000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fd588bfe000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fd588bdb000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fd588a8c000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fd588a86000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd588894000)
/lib64/ld-linux-x86-64.so.2 (0x00007fd588f4e000) |
The release with assets is here: I'll keep it for now (in case anyone wants to test it) but I'll delete it before making an actual |
This looks like a good change but why do we need to keep the dynamically linked one? |
It's a bit awkward situation due to mutual dependency. Lines 86 to 96 in 65b53bd
And it's used in tests: tool-sync/.github/workflows/ci.yml Line 100 in 65b53bd
Unfortunately, GitHub API doesn't return So the easiest solution would be to just keep both of them and remove the dynamically linked asset for the |
Resolves #87