Dynamic autocompletion

[setnicka]

I implemented dynamic autocompletion mechanism.

Now there is a new item type "PcItemDynamic" which takes function as
parameter.

When it comes to autocomplete at this position, the function is called,
the whole line is given to it (for example if autocompletion depend on
previous autocompleted field) and functio should return possible strings
how to continue.

Example usage:

• listing some dynamic key-value storage
• listing files in directory

[setnicka]

Tested on Debian 5.4.0-3 and Win10, it seems working fine :-)

[chzyer]

@setnicka
I think we should use a new interface to make sure that it's backward compatibility?

[setnicka]

@chzyer
Yes, it would be better. But this will probably yields to duplicate almost every function in completer_helper.go (because we will need to have old version od PrefixCompleter struct and new DynamicPrefixCompleter struct).

Or have you better idea?

And is there reason to use PrefixCompleterInterface interface outside this module?

[chzyer]

Hi! @setnicka , sorry for the lated reply.
How about this:

type DynamicPrefixCompleterInterface interface {
    PrefixCompleterInterface
    IsDynamic() bool
    GetDynamicNames(line []rune) [][]rune
}

In function Do, we just assert whether PrefixCompleterInterface is DynamicPrefixCompleterInterface.
And please add a new function instead of changing the declaration of Do. :)
Thanks!

[chzyer]

BTW, Dynamic autocompletion is really a very cool feature!

[setnicka]

Sorry for lated reply too (summer trips, camps, etc).

I added DynamicPrefixCompleterInterface like you suggested and yes, it looks good for me now :-)

Plus I split Do function into doInternal with added parameter and original Do with the original declaration.

[setnicka]

Is there something I should fix/modify, or it can be merged?

[chzyer]

Not yet. Sorry about that.
I just want to review the code more deeply, I will got some time at weekend :)

[setnicka]

Ok, it's fine, thank you :-)

[chzyer]

👍 It looks very cool!

[gotwarlost]

There is a lot of cool stuff in this code that I wish the docs would explain and give examples for. Every time I think I need something, I come across a type that already seems to do it (fair warning: I have exactly 1 day exposure to this code).

I'll figure out what everything does (eventually :) - there is a lot of stuff). Would you be open to accepting a PR with godoc additions and examples only?

[chzyer]

@gotwarlost
That's welcome :)