Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
cibernox committed Apr 22, 2018
1 parent 850c227 commit 930d2ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- [CLEANUP] Remove unnecessary `self.` prefix to access a few globals like `document` or `window`.
# 1.0.0-beta.6
- [CLEANUP] Remove passing `to="id-of-destination"` that has been deprecated for a long time.

Expand Down
2 changes: 1 addition & 1 deletion addon/components/basic-dropdown/trigger.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { readOnly } from "@ember/object/computed";
import layout from '../../templates/components/basic-dropdown/trigger';
import fallbackIfUndefined from '../../utils/computed-fallback-if-undefined';

const isTouchDevice = (!!window && 'ontouchstart' in window);

This comment has been minimized.

Copy link
@mehanika

mehanika Apr 26, 2018

Contributor

Hi @cibernox, I think that by accident you added self on this line. Im not sure why did It work when I test it but now is not.

const isTouchDevice = (!!self.window && 'ontouchstart' in self.window);

function trueStringIfPresent(path) {
return computed(path, function() {
Expand Down

0 comments on commit 930d2ea

Please sign in to comment.