Fixed state not being reset to correct value when transitioning out #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dardalan
commented
Aug 19, 2021
alex-konoval
approved these changes
Aug 19, 2021
dardalan
force-pushed
the
bugfix/reset-animation-state
branch
from
1434264
to
f60a8fe
Compare
|
@dardalan @alex-konoval This PR seems to correctly fix the issue. Is there something missing before it can be merged ? Can I help ? |
|
Sorry for neglecting this for so long. If you can rebase it and add an entry to the changelog I'll merge it today. |
@cibernox no worries, will try to update it asap. |
dardalan
force-pushed
the
bugfix/reset-animation-state
branch
from
f60a8fe
to
555a536
Compare
|
@cibernox Please check it out, when you have a time. |
@cibernox can you check please and merge if all is good? |
added 2 commits
December 7, 2021 18:35
|
Thanks! Merged! |
|
Great! 🙏 |
|
@cibernox Thanks! |
|
@cibernox Would you cut a release? 🙌 |
|
Released in 4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already opened pr on this Issue #623
but i am not sure we should make any changes on this code ember-basic-dropdown, cause on production code - it works good, the only problem with tests, so i made a workaround for testing purpose. Any idea how to fix this issue better, very welcome.
The transitioning--in etc classes don't get reset after the first render. When the dropdown content first renders, it animates correctly, but on subsequent renders there is no animation - cause state not being reset to correct value.
Looks like it was broken here in this commit, so idea to revert back and cover with tests:
1819c01#diff-73297f8c71645544a2a6826e5c3146aff7cb2333d9c17fe968258e5f14dc4a79R164