-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Adds support for decorators #52
[BUGFIX] Adds support for decorators #52
Conversation
This PR adds general support for decorators when used within markdown blocks. It does this by reaching into the YUIDoc global and patching the method that handles comment parsing. Given YUIDoc is pretty much abandoned at this point, this should be a relatively stable patch. Presumably, attempts to modernize it will also add decorator support, should they occur. The fix replaces all @ symbols within codeblocks with a placeholder, processes them, and then switches them back after processing.
LGTM. |
Oops, I misread the diff, sorry. This only replaces |
Is this a problem that YUIDoc should fix? |
@rwjblue If you think this can be merged as is, I'll merge it and release a new version today |
@okuryu unfortunately YUIDoc is a dead project (hasn’t merged a commit in 4years or so now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, this fix looks good to me. We could do a follow up to add support for the indented format, but I kinda doubt we use it much (since we use the code fences to invert type, file name, etc).
Yes. If this is a bug that should be fixed in YUIDoc, I thought I could cooperate. |
Ah, didn't realize you were a maintainer! Let me see if I can adapt my fix to the existing code, would love to fix this upstream! |
Thanks. If you are in a hurry to fix this issue, please free to merge this PR. Fixing the upstream are also welcomed. I think I can take a look too. |
Yeah, I think this would still be good to merge, since the upstream fix may require more changes (for instance to handle indented markdown examples, or |
Published in 0.9.0 |
This PR adds general support for decorators when used within markdown blocks.
It does this by reaching into the YUIDoc global and patching the method that
handles comment parsing. Given YUIDoc is pretty much abandoned at this point,
this should be a relatively stable patch. Presumably, attempts to modernize it
will also add decorator support, should they occur.
The fix replaces all @ symbols within codeblocks with a placeholder, processes
them, and then switches them back after processing.