Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecations #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve deprecations #145

wants to merge 1 commit into from

Conversation

cibernox
Copy link
Owner

@iezer I'm working on improving the deprecations.

@iezer
Copy link

iezer commented Feb 22, 2018

@cibernox Awesome, thanks for picking this up. I wonder if it's possible to detect if a user is using the old syntax of moduleFor and passing beforeEach and afterEach, versus the new syntax of calling module and setupRenderingTest.

@cibernox
Copy link
Owner Author

@iezer That is what I'm doing here: https://github.com/cibernox/ember-native-dom-helpers/pull/145/files#diff-36ccf1b6880df69c7336caa0370773df

I'll try to find time to finish it tomorrow or on saturday.

@iezer
Copy link

iezer commented Feb 22, 2018

👍 That looks great. I misread that as merely checking for @ember/test-helpers but now I see you're checking !!getContext()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants