Bind title to the trigger (#1126)

cibernox · Jun 21, 2018 · 7ffe3f0 · 7ffe3f0
1 parent c2f3bc1
commit 7ffe3f0
Show file tree

Hide file tree

Showing 6 changed files with 472 additions and 510 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 # Master
 
+- [FEATURE] You can add a title to the trigger by passing `title="The title"` to `{{power-select}}` or `{{power-select-multiple}}`
+
 # 2.0.3
 - [BUGFIX] Remove forgoten console statement in test helper
 

diff --git a/addon/templates/components/power-select-multiple.hbs b/addon/templates/components/power-select-multiple.hbs
@@ -49,6 +49,7 @@
     selectedItemComponent=selectedItemComponent
     tabindex=computedTabIndex
     tagName=tagName
+    title=title
     triggerClass=concatenatedTriggerClass
     triggerComponent=(component triggerComponent tabindex=tabindex)
     triggerId=triggerId
@@ -109,6 +110,7 @@
     selectedItemComponent=selectedItemComponent
     tabindex=computedTabIndex
     tagName=tagName
+    title=title
     triggerClass=concatenatedTriggerClass
     triggerComponent=(component triggerComponent tabindex=tabindex)
     triggerId=triggerId

diff --git a/addon/templates/components/power-select.hbs b/addon/templates/components/power-select.hbs
@@ -22,6 +22,7 @@
     ariaLabel=(readonly ariaLabel)
     ariaLabelledBy=(readonly ariaLabelledBy)
     ariaRequired=(readonly required)
+    title=(readonly title)
     class=(readonly concatenatedTriggerClasses)
     extra=(readonly extra)
     id=(readonly triggerId)

diff --git a/tests/integration/components/power-select/general-behaviour-test.js b/tests/integration/components/power-select/general-behaviour-test.js
@@ -1205,4 +1205,17 @@ module('Integration | Component | Ember Power Select (General behavior)', functi
     assert.dom('.ember-power-select-option').exists({ count: 1 });
     assert.dom('.ember-power-select-option').hasClass('ember-power-select-option--loading-message');
   });
+
+  test('The title is rendered in the trigger', async function (assert) {
+    assert.expect(1);
+
+    this.numbers = numbers;
+    await render(hbs`
+      {{#power-select options=numbers onchange=(action (mut foo)) title="The title" as |option|}}
+        {{option}}
+      {{/power-select}}
+    `);
+
+    assert.dom('.ember-power-select-trigger').hasAttribute('title', 'The title');
+  });
 });
diff --git a/tests/integration/components/power-select/multiple-test.js b/tests/integration/components/power-select/multiple-test.js
@@ -825,4 +825,17 @@ module('Integration | Component | Ember Power Select (Multiple)', function(hooks
     `);
     assert.dom('.ember-power-select-multiple-options .ember-power-select-multiple-option--disabled').exists({ count: disabledNumCountries }, 'The class "ember-power-select-multiple-option--disabled" is added to disabled options');
   });
+
+  test('The title is rendered in the trigger of multiple selects', async function (assert) {
+    assert.expect(1);
+
+    this.numbers = numbers;
+    await render(hbs`
+      {{#power-select-multiple options=numbers onchange=(action (mut foo)) title="The title" as |option|}}
+        {{option}}
+      {{/power-select-multiple}}
+    `);
+
+    assert.dom('.ember-power-select-trigger').hasAttribute('title', 'The title');
+  });
 });