Error with ember 3.1

[Titinux]

Hi, I recently updated ember to version 3.1 and now ember-power-select is not working if I use the selected option.

{{#power-select options=layouts
    selected=selectedLayout
    onchange=(action (mut selectedLayout)) as |layout|}}
  {{layout.name}}
{{/power-select}}

layouts is the result of

this.get('store').findAll('layout')

The error message is

Error: Assertion Failed: You attempted to access the `then` property (of <(unknown mixin):ember757>).
Since Ember 3.1, this is usually fine as you no longer need to use `.get()`
to access computed properties. However, in this case, the object in question
is a special kind of Ember object (a proxy). Therefore, it is still necessary
to use `.get('then')` in this case.

If you encountered this error because of third-party code that you don't control,
there is more information at https://github.com/emberjs/ember.js/issues/16148, and
you can help us improve this error message by telling us more about what happened in
this situation.

it seems to come from this line

ember-power-select/addon/components/power-select.js

Line 141 in 97621af

if (selected && selected.then) {

[cibernox]

Yeah, someone reported it in emberjs/ember.js#16148 (comment) but I don't have a clear understanding of what the fix is. I'll try to allocate some time to investigate it, but if you have time by all means, go for it.

[donaldwasserman]

@cibernox @Titinux - I submitted a PR. As I explain in the #1097, I don't know if it's the most elegant, but at least it works.

[cibernox]

Released in 2.0.0-beta.4

[huberts]

I tried to pindown this bug, but I have no working (simple) example. I have spotted this in my application, but it was so deep down nested it could not work as a snippet. I will take the beta.4 version and check it. Thanks!

[andrewtimberlake]

This is still a problem with [email protected]
If I remove the selected= the error goes away.

It happens after the above mentioned if(selected && selected.then), which is changed.
It happens within the call to this.get('_updateSelectedTask').perform(selected);

Error:

Error: Assertion Failed: You attempted to access the `then` property (of <(unknown mixin):ember1188>).
Since Ember 3.1, this is usually fine as you no longer need to use `.get()`
to access computed properties. However, in this case, the object in question
is a special kind of Ember object (a proxy). Therefore, it is still necessary
to use `.get('then')` in this case.

[cibernox]

If you're in the latest version it means you still have an old version of ember-concurrency installed. Can you update EC and see how it goes?

[andrewtimberlake]

Updated, still an error with [email protected]

[donaldwasserman]

I use this all over the place in two different apps and don't really see this error. Is it on Ember 3.1 or 3.2?

@andrewtimberlake Can you copy and paste and example of your usage? Are you using the EC-powered search? e\Also, I noticed a similar problem before with conflicting versions between EC in my host app and EC required by power select where my app wasn't using the latest version of EC.

@cibernox Looking through the code, there's a handful of more usages of if (<Task>.then). Would it be good to just switch them all over to use get(<thing>, 'then')?

[cibernox]

What would help. Perhaps that's the problem and it just happens that I haven't exercised that code.

[andrewtimberlake]

I don’t know if this helps diagnose the problem, my selected is an object from a DS.belongsTo()

[cibernox]

Just in case I release a new version in which I which I replaced if (obj.then) by if (get(obj, 'then'). Check if that helps.

[andrewtimberlake]

@cibernox, That didn’t change things.

I have put up a test repo that reproduces a similar issue. I am running my model through Ember Changeset which seems to be the cause of the problem. I don’t know if the problem is with Ember Changeset or with the fact that EC returns a proxy object.
The repo is at https://github.com/andrewtimberlake/ember-power-select-test-1094

[donaldwasserman]

I think it's because the relationship returns as DS.PromiseObject can you try making the relationship DS.BelongsTo('user', {async: false}) and then make sure the record is loaded into the store?

[andrewtimberlake]

Thanks everyone for the help.
{async: false} and preloading was the answer