-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop click propagation added to the docs #1087
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import Controller from '@ember/controller'; | ||
|
||
export default Controller.extend({ | ||
names: ['Stefan', 'Miguel', 'Tomster', 'Pluto'], | ||
actions: { | ||
stopPropagation(e) { | ||
e.stopPropagation(); | ||
}, | ||
removeName(name) { | ||
alert(`remove name: ${name}`); | ||
} | ||
} | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{{#power-select | ||
options=names | ||
renderInPlace=true | ||
selected=name345 | ||
onchange=(action (mut name345)) | ||
as |name| | ||
}} | ||
{{name}} | ||
<a onmouseup={{action "stopPropagation"}} | ||
onclick={{action "removeName" name}}>x</a> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted Miguel, gonna make both changes pretty soon, do you know why the travis build is failing ? will that be a problem ? |
||
{{/power-select}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a note saying something: "This is particularly useful if you want to add some kind of link or button inside the list of option and prevent the option that contains it from being selected when the user clicks on them"