-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Hey, any remark on this PR ? I would be interested in using this in prod. Thanks ! |
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this getting added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was still there. I just upgraded the version from 0.8 to 1.0 in my previous PR.
The dependency with leafletpm is absolutely welcome. |
I developed this to take advantages of the npm mechanism. Actually it is also implemented in scalajs-bundler but it comes in my plugin with less stuff. What I wanted is getting a mechanism that permits to depends on js libraries (as we would depend on a scala library) and to gather all js deps in one single deps.js, with no extra stuff like webpack. The js deps are managed transitively. And it works fine; it is just a couple of sbt rules to make the scala-js dev easier. And you are very welcome to contribute in this plugin scalajs-execnpm |
So ? |
Thanks ! |
Could you publish a version ? A snapshot is enough for now if you prefer not to release now. |
The changes to build.sbt broke the release process. There are several changes here that don't make much sense: the |
OK, I will fix this. Do you really think the example needs to be published ? |
Well, I don't think it needs to be published. I don't think it was being published before. |
Well, I don't see any problem in the build.sbt. All the modules depends on the globalSettings (except the example one). I can't test it, I don't have credentials (and it is the only error I get when I try to publish). What error do you get if you publish ? |
As I mentioned, the
But after the changes, it's now
The two errors I see are in regards to the
|
It's normal you don't get a None for example since the settings are not set for this module. I removed the root so that each module is published separately. It is cool to only depends on one aspect and not on the whole project. Typically, someone could be interested in the leaflet-facade but not in the pm one. So, the error is about the default-274479, which should be a kind of root project. It is created because the 'homepage' and the 'headerLicence' variables are defined outside the globalSettings. I do not remember why I set them outside. Moving them in the globalSettings should fix the problem. |
So, if people won't want to depend on the |
Someone may be interested in leaflet-facade only but not in pm. The modularity enables to choose exactly what you want and not to depend on modules you don't need. Imagine, we add 100 other modules around leaflet, it is sure that a no one will need all of them together. In this context, the root project is useless. Try a publishLocal, you'll see the result. Did you try to move the homepage and the headerLicence in the globalSettings ? |
This reverts commit 8da56dc.
This PR contains several things: