internal/cli/cmd: mark --skip-ip-cache-check as hidden

Follow-up for #503 to address #503 (comment) Also add a comment so we don't forget to re-enable the check again once issue #361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
cilium · Sep 1, 2021 · 89639cb · 89639cb
1 parent 088eb3f
commit 89639cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/connectivity/check/deployment.go b/connectivity/check/deployment.go
@@ -477,6 +477,8 @@ func (ct *ConnectivityTest) validateDeployment(ctx context.Context) error {
 		}
 	}
 
+	// TODO: unconditionally re-enable the IPCache check once
+	// https://github.com/cilium/cilium-cli/issues/361 is resolved.
 	if ct.params.SkipIPCacheCheck {
 		ct.Infof("Skipping IPCache check")
 	} else {

diff --git a/internal/cli/cmd/connectivity.go b/internal/cli/cmd/connectivity.go
@@ -120,6 +120,7 @@ func newCmdConnectivityTest() *cobra.Command {
 	cmd.Flags().BoolVarP(&params.Debug, "debug", "d", false, "Show debug messages")
 	cmd.Flags().BoolVarP(&params.PauseOnFail, "pause-on-fail", "p", false, "Pause execution on test failure")
 	cmd.Flags().BoolVar(&params.SkipIPCacheCheck, "skip-ip-cache-check", true, "Skip IPCache check")
+	cmd.Flags().MarkHidden("skip-ip-cache-check")
 
 	return cmd
 }