CODEOWNERS: Assign vendor/ to cilium-cli-maintainers #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the Go code has been moved to cilium/cilium repo [^1], and the only direct dependencies are cilium/cilium and google/gops at this point. I don't think it makes much sense to pull in the vendor team for reviewing new versions of cilium and / or gops. I'm imagining the new release process will look something like this: - Renovate picks up a new cilium/cilium pre-release from main branch. Pre-releases happen roughly once a month. - cilium-cli-maintainers team approves and merges the Renovate PR. - cilium-cli-maintainers team cuts a new cilium-cli release. [^1]: cilium/cilium#34178 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
requested review from
a team,
marseel and
tklauser
and removed request for
a team
bimmlerd
approved these changes
Aug 20, 2024
marseel
approved these changes
Aug 20, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the Go code has been moved to cilium/cilium repo 1, and the only direct dependencies are cilium/cilium and google/gops at this point. I don't think it makes much sense to pull in the vendor team for reviewing new versions of cilium and / or gops. I'm imagining the new release process will look something like this:
Footnotes
https://github.com/cilium/cilium/pull/34178 ↩